git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>]

From
Jeff King <peff@peff.net>
Date
Mar 26, 2010, 20:33 UTC
Message-ID
<20100326203303.GB22900@coredump.intra.peff.net>
In-Reply-To
<alpine.DEB.1.00.1003261712100.7596@pacific.mpi-cbg.de>
On Fri, Mar 26, 2010 at 05:14:46PM +0100, Johannes Schindelin wrote:
> In addition to the disadvantages you are listing, it does not jump 
> directly to the word I am looking for. As you know, I am working 
> with LaTeX files heavily, where convention dictates that a paragraph is 
> represented by a single line in the source code.

Sure, that is a reasonable feature to want that my solution did not have (though I have never seen LaTeX code with that requirement; I wrap my lines at a reasonable width and separate paragraphs with a blank line).

> So yes, I really need -O, and if a colleague would not have asked me why 
> this useful feature is not in upstream Git, I would not even have 
> submitted the patch pair.

Yep. That is why I started my mail with "this is not an argument against your patch". I was just trying to be helpful and offer a possible alternative.

-Peff
Previous: Johannes SchindelinNext: Junio C Hamano
Message 13 of 20 in “Teach 'git grep' about --open-files-in-pager=[<pager>]”
  1. 0/2 Teach 'git grep' about --open-files-in-pager=[<pager>]Johannes Schindelin, Mar 26, 2010
  2. 1/2 grep: Add the option '--open-files-in-pager'Johannes Schindelin, Mar 26, 2010
  3. Jonathan NiederMar 28, 2010
  4. Johannes SchindelinMar 29, 2010
  5. Junio C HamanoMar 29, 2010
  6. 2/2 grep -P: allow optional argument specifying the pager (or editor)Johannes Schindelin, Mar 26, 2010
  7. Johannes SchindelinMar 26, 2010
  8. Bert WesargMar 26, 2010
  9. Johannes SchindelinMar 26, 2010
  10. Bert WesargMar 26, 2010
  11. Jeff KingMar 26, 2010
  12. Johannes SchindelinMar 26, 2010
  13. Jeff KingMar 26, 2010
  14. Junio C HamanoMar 26, 2010
  15. Francis MoreauMar 26, 2010
  16. Junio C HamanoMar 27, 2010
  17. Francis MoreauMar 27, 2010
  18. Junio C HamanoMar 27, 2010
  19. Francis MoreauMar 27, 2010
  20. Jon SeymourMar 26, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.