jgit diff, was Re: [JGIT] Request for help

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 3, 2009, 06:55 UTC
Message-ID: <alpine.DEB.1.00.0909030846230.8306@pacific.mpi-cbg.de>
In-Reply-To: <20090903012207.GF1033@spearce.org>

Hi,

On Wed, 2 Sep 2009, Shawn O. Pearce wrote:

Show 18 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > On Wed, 2 Sep 2009, Nasser Grainawi wrote:
> > 
> > > I'm looking to add 'git patch-id' to JGit and I could use a few 
> > > pointers. I'm not very familiar with the JGit code base or Java, so 
> > > please excuse any blatant oversights or unintelligent questions.
> > > 
> > > First off, is there a "hacking JGit" document anywhere? One of those 
> > > would be great right now.
> > 
> > There have been some mails with details about JGit from Shawn (IIRC) 
> > to this very list.
> 
> Yea, for the most part I think we use Eclipse, and you just have to 
> import JGit's top level directory into Eclipse as it comes with Eclipse 
> project files.  But I know some folks only use our Maven build (under 
> jgit-maven/jgit) or use NetBeans.  I have no idea how to import the 
> project into the latter or configure its unit tests to run.

FWIW I use vim & shell most of the time (yes, even for JGit).

Show 5 quoted lines

> > This is not really difficult in Java, however, it relies on a working 
> > diff implementation (and IIRC my implementation has not yet been 
> > integrated into JGit).
> 
> Speaking of... where does that stand?

Same as where I left off. IOW it is a working implementation that saw some testing, but I simply lack the time for performance tuning.

It should not be all that bad, though.

***goes looking at http://repo.or.cz/w/jgit/dscho.git?a=shortlog;h=refs/heads/diff ***

Seems I misremembered a bit. Christian provided a patch to make it compileable, but I think that I ran the script to verify that the diffs are correct on jgit.git and IIRC it completed fine.

There is a project in my day-job, however, which eats all my time at the moment (it is actually wrapping up a "succeeded" GSoC project where the student -- *sigh* -- has gone away). So all I can do is to rebase to current jgit.git's 's master, to run the script, and submit the current patch series (valuing correctness over speed).

Ciao, Dscho