Re: [JGIT] Request for help
- From
Nasser Grainawi <nasser@codeaurora.org>
- Date
- Sep 3, 2009, 21:09 UTC
- Message-ID
- <4AA0308F.9@codeaurora.org>
- In-Reply-To
- <20090903194955.GL1033@spearce.org>
Shawn O. Pearce wrote:
Show 17 quoted lines
> Nasser Grainawi <nasser@codeaurora.org> wrote: >> Shawn O. Pearce wrote: >>> Hmm, maybe a method on Patch is reasonable. >> Going down this route, I'd add a few things to Patch. >> patchId would be a private field (of type ObjectId?) >> getPatchId would be a public method that returns patchId >> and then likely a private method (computePatchId?) that actually >> generates the patchId > > Sure, but getPatchId can compute it on demand on the first call, > and anyone who modifies the Patch would just need to clear out > the cached patchId value so the next call (if it ever comes) to > getPatchId would force it to recompute. > > Most users of Patch won't want the patchId, so there is no reason > to compute it. >
Works for me, that's even easier. I'll get to work on implementing this, but between (re-)learning Java and our legal dept, don't know when I'll have a finished product to share...
I'll continue to post questions as I get them. Thanks everyone for their help thus far :)