[JGIT] Request for help

Hello all,

I'm looking to add 'git patch-id' to JGit and I could use a few pointers. I'm not very familiar with the JGit code base or Java, so please excuse any blatant oversights or unintelligent questions.

First off, is there a "hacking JGit" document anywhere? One of those would be great right now.

So far I'm just trying to define the inputs and outputs. On Shawn's suggestion I'm planning on making it part of the org.spearce.jgit.patch package. C Git patch-id very generically has an input of a 'patch', so I'm thinking this implementation should use the Patch object. Looking at that class it seems that has everything patch-id should need, so perhaps that's the only input.

As far as output, C Git patch-id has the special feature to output the commit-id along with the patch-id when it gets input in the format of git-diff-tree. Should JGit do the same or just return the patch-id? I don't know that this question even makes sense in the context of JGit (since the commit-id is almost certainly available elsewhere and someone calling 'getPatchId()' is likely only interested in the patch-id).

Should PatchId be a class on its own, or just a method within the Patch class?

Thanks, Nasser