Re: [JGIT] Request for help

From: Shawn O. Pearce <spearce@spearce.org>
Date: Sep 3, 2009, 15:52 UTC
Message-ID: <20090903155219.GI1033@spearce.org>
In-Reply-To: <2c6b72b30909030838q10b88705gb8c553f2c2d74379@mail.gmail.com>

Jonas Fonseca <jonas.fonseca@gmail.com> wrote:

Show 10 quoted lines

> On Thu, Sep 3, 2009 at 10:42, Shawn O. Pearce<spearce@spearce.org> wrote:
> > Actually, now that we have forked out of the egit.git repository,
> > I want to refactor the layout of the JGit project to be more maven
> > like, and have a proper top-level pom to build things.
> 
> What kind of module structure do you have in mind? Do you want to move
> some of the modules/subdirectories?
> Some refactoring of the maven setup for JGit back was done back in
> April in sonatype's (a maven company) JGit clone. It is not
> signed-off, but can serve as a reference.

Yea, I was hoping they would contribute this back as patches,
but thus far they haven't.

Show 10 quoted lines

> The Maven layout in the sonatype clone simply uses the Eclipse project layout.
> 
> pom.xml: JGit :: Parent
>  |- org.spearce.jgit/pom.xml: JGit :: Core
>  |- org.spearce.jgit.pgm/pom.xml: JGit :: Programs
>  `- org.spearce.jgit.test/pom.xml: JGit :: Test
> 
> However, having tests in a separate module can be both good/bad. For
> example, they will not automatically get run when you only build the
> Core module.

Yea, I know. This is one area where Maven is just whack, by putting the tests in the same project the Maven plugin for Eclipse puts them into the same classpath, which means you can see test code from project code. Wrong. They should be different projects so the test classpath is isolated.

However. This is a bug in the Eclipse plugin I think, not necessarily with Maven's approach of trying to keep tests alongside the code they test. Thus we probably want:

  pom.xml: JGit :: Parent
   |- jgit-lib/pom.xml: JGit
   |     src/main/java  <-- from org.spearce.jgit/src
   |     src/test/java  <-- from org.spearce.jgit.test/src
   |
   `- jgit-pgm/pom.xml: JGit pgm
         src/main/java  <-- from org.spearce.jgit.pgm/src

IIRC there is Maven support to create proper MANIFEST.MF files for OSGI bundles, which is what we need for the Eclipse plugin support. That should be able to replace the META-INF/MANIFEST.MF in the top of each of the current directories.

> Anyway, I would like to help.

Please post patches; formatted with -M. I do want to do this, I just don't have the patience and Maven-fu to write the new poms myself.

-- 
Shawn.