Re: [PATCH] git-gui: make "Git GUI Here" Explorer extension more robust

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 30, 2009, 08:03 UTC
Message-ID: <alpine.DEB.1.00.0903301001090.7534@intel-tinevez-2-302>
In-Reply-To: <200903300851.43164.markus.heidelberg@web.de>

Hi,

On Mon, 30 Mar 2009, Markus Heidelberg wrote:

Show 18 quoted lines

> Johannes Schindelin, 30.03.2009:
> 
> > On Mon, 30 Mar 2009, Markus Heidelberg wrote:
> > 
> > > Starting git-gui via Windows Explorer shell extension caused 
> > > problems when not started from the project directory, but from a 
> > > directory within the project: starting the Explorer from the git-gui 
> > > menu "Explore Working Copy" didn't work then.
> > > 
> > > Starting git-gui via Explorer shell extension from the .git 
> > > directory didn't work at all.
> > > 
> > > To make these things possible, "cd .." until we see .git/
> > 
> > How does this interact with GIT_WORK_TREE?
> 
> Not sure. What's the use case for a globally set GIT_WORK_TREE, how is 
> it used?

You can call git gui with a non-global GIT_WORK_TREE by something like this, even on Windows (which your patch does not special case, anyway):

	$ GIT_WORK_TREE=/bla/blub git gui

Show 5 quoted lines

> > And with bare repositories?
> 
> Git-gui doesn't seem to work with bare repositories, I get
> "Cannot use funny .git directory: ."
> when started on the command line.

Oh? I thought there was some discussion recently that was explicitely about git gui with bare repositories. But I have to time-share my brain these days, so my memory might well show some bit flips.

Ciao, Dscho