Re: [PATCH] git-gui: make "Git GUI Here" Explorer extension more robust

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Mar 30, 2009, 20:20 UTC
Message-ID: <200903302220.44564.markus.heidelberg@web.de>
In-Reply-To: <alpine.DEB.1.00.0903301001090.7534@intel-tinevez-2-302>

Johannes Schindelin, 30.03.2009:

Show 27 quoted lines

> Hi,
> 
> On Mon, 30 Mar 2009, Markus Heidelberg wrote:
> 
> > Johannes Schindelin, 30.03.2009:
> > 
> > > On Mon, 30 Mar 2009, Markus Heidelberg wrote:
> > > 
> > > > Starting git-gui via Windows Explorer shell extension caused 
> > > > problems when not started from the project directory, but from a 
> > > > directory within the project: starting the Explorer from the git-gui 
> > > > menu "Explore Working Copy" didn't work then.
> > > > 
> > > > Starting git-gui via Explorer shell extension from the .git 
> > > > directory didn't work at all.
> > > > 
> > > > To make these things possible, "cd .." until we see .git/
> > > 
> > > How does this interact with GIT_WORK_TREE?
> > 
> > Not sure. What's the use case for a globally set GIT_WORK_TREE, how is 
> > it used?
> 
> You can call git gui with a non-global GIT_WORK_TREE by something like 
> this, even on Windows (which your patch does not special case, anyway):
> 
> 	$ GIT_WORK_TREE=/bla/blub git gui

The patch only affected git-gui started via Explorer, i.e. invoked with --working-dir. But it's right that core.worktree can be set in the repository. However, git-gui currently doesn't support the gitdir outside of the working directory, but it may not be wise to build up on this!?

Hmm, more complicated than I initially thought.

Markus