Re: [PATCH] git-gui: make "Git GUI Here" Explorer extension more robust

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Mar 30, 2009, 06:51 UTC
Message-ID: <200903300851.43164.markus.heidelberg@web.de>
In-Reply-To: <alpine.DEB.1.00.0903300243050.6454@intel-tinevez-2-302>

Johannes Schindelin, 30.03.2009:

Show 15 quoted lines

> Hi,
> 
> On Mon, 30 Mar 2009, Markus Heidelberg wrote:
> 
> > Starting git-gui via Windows Explorer shell extension caused problems 
> > when not started from the project directory, but from a directory within 
> > the project: starting the Explorer from the git-gui menu "Explore 
> > Working Copy" didn't work then.
> > 
> > Starting git-gui via Explorer shell extension from the .git directory 
> > didn't work at all.
> > 
> > To make these things possible, "cd .." until we see .git/
> 
> How does this interact with GIT_WORK_TREE?

Not sure. What's the use case for a globally set GIT_WORK_TREE, how is it used?

> And with bare repositories?

Git-gui doesn't seem to work with bare repositories, I get "Cannot use funny .git directory: ." when started on the command line.

But I just noticed, that it will obviously "cd .." forever, if no .git/ was found. Somehow the root directory has to be catched.

Markus