Re: [PATCH] git-gui: make "Git GUI Here" Explorer extension more robust

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Mar 31, 2009, 23:59 UTC
Message-ID: <200904010159.24764.markus.heidelberg@web.de>
In-Reply-To: <499F039601E4A981@joe.mail.tiscali.sys>

Giuseppe Bilotta, 31.03.2009:

Show 19 quoted lines

> On Monday 30 March 2009 16:15, Shawn O. Pearce wrote:
> 
> > Markus Heidelberg <markus.heidelberg@web.de> wrote:
> >> 
> >> But I just noticed, that it will obviously "cd .." forever, if no .git/
> >> was found. Somehow the root directory has to be catched.
> > 
> > Yup.  I'm dropping this patch for now because of this issue, but
> > I'll look at it again if its addressed in another version.  :-)
> 
> I have a couple of pending patches to fix git gui handling of repositories,
> including support for nonstandard repository locations and bare repositories.
> You can find them at
> 
> http://git.oblomov.eu/git
> 
> and specifically
> 
> http://git.oblomov.eu/git/patches/b2e4c32e13df1b7f18e7b4a9f746650471a3122e..a63526bf3238cf25d9a5521f7ee35ed1bd11cb16

I just tried these two patches on Windows (Uhh, Qemu is too slow for this, I have to setup something else).

> I got distracted by real-life issue and forgot to resend them. I'll try
> to find the time again later on this week. I'm not entirely sure these
> solve Markus' problem though.

Starting git-gui via Explorer "Git GUI Here" is now possible from the .git/ directory with your patches, but it doesn't show the working tree status. Also "Explore Working Copy" wants to open the .git directory then instead of the project directory (I say "want" because of the issue I just sent a patch out). It seems to be as non-functional as if you run "git status" inside of .git/

Markus