git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/6] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 10, 2009, 14:34 UTC
Message-ID
<alpine.DEB.1.00.0901101532430.30769@pacific.mpi-cbg.de>
In-Reply-To
<1231595452-27698-3-git-send-email-prohaska@zib.de>
Hi,
On Sat, 10 Jan 2009, Steffen Prohaska wrote:
Show 17 quoted lines
> From: Steve Haslam <shaslam@lastminute.com>
> 
> If the user specified the full path to git-upload-pack as the -u option to
> "git clone" when cloning a remote repository, and git was not on the default
> PATH on the remote machine, git-upload-pack was failing to exec
> git-pack-objects.
> 
> By making the argv[0] path (if any) available to setup_path(), this will
> allow finding the "git" executable in the same directory as
> "git-upload-pack". The default built in to exec_cmd.c is to look for "git"
> in the ".../libexec/git-core" directory, but it is not installed there (any
> longer).
> 
> Much the same applies to invoking git-receive-pack from a non-PATH location
> using the "--exec" argument to "git push".
> 
> [ spr: split Steve's original commit into two commits. ]

I think you do not want to have that [ ... ] in the commit message, but after the "--".

Further, it would make sense to have these 2 patches independently, provided that a test is added with which we could verify that the patches are actually necessary for upload-pack/receive-pack.

Logically, and to avoid committing a broken revision, 1/6 should come last, methinks.

Ciao, Dscho

Previous: Steffen ProhaskaNext: Steffen Prohaska
Message 7 of 16 in “Move computation of absolute paths from Makefile to runtime and compute prefix on the fly if RUNTIME_PREFIX set”
  1. 1/6 Move computation of absolute paths from Makefile to runtime and compute prefix on the fly if RUNTIME_PREFIX setSteffen Prohaska, Jan 10, 2009
  2. 2/6 Refactor git_set_argv0_path() to git_extract_argv0_path()Steffen Prohaska, Jan 10, 2009
  3. 3/6 Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.Steffen Prohaska, Jan 10, 2009
  4. 4/6 Add calls to git_extract_argv0_path() in programs that call git_config_*Steffen Prohaska, Jan 10, 2009
  5. 5/6 Modify setup_path() to only add git_exec_path() to PATHSteffen Prohaska, Jan 10, 2009
  6. 6/6 Windows: Revert to default paths and convert them by RUNTIME_PREFIXSteffen Prohaska, Jan 10, 2009
  7. Johannes SchindelinJan 10, 2009
  8. Steffen ProhaskaJan 10, 2009
  9. Steffen ProhaskaJan 10, 2009
  10. Junio C HamanoJan 10, 2009
  11. Steffen ProhaskaJan 11, 2009
  12. Junio C HamanoJan 11, 2009
  13. Steffen ProhaskaJan 11, 2009
  14. Johannes SixtJan 13, 2009
  15. Johannes SixtJan 13, 2009
  16. Johannes SixtJan 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.