git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/6] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.

From
Steffen Prohaska <prohaska@zib.de>
Date
Jan 11, 2009, 12:57 UTC
Message-ID
<C817EA53-5326-4C60-B781-41B90514F3A7@zib.de>
In-Reply-To
<7v1vvata6o.fsf@gitster.siamese.dyndns.org>
On Jan 11, 2009, at 11:21 AM, Junio C Hamano wrote:
Show 25 quoted lines
> My initial impression after reading 1/6 was that no matter how the  
> actual
> runtime prefix detection logic that is implemented in the later  
> parts of
> the series for particular platform will turn out to be, the update  
> to the
> Makefile that is done by 1/6 won't have to change.  If I apply 1/6  
> first
> without applying anything else, we can make sure that it would not  
> regress
> for Unix people (and catch regressions early if any), while Windows  
> people
> polish the platform specific parts of the implementation in the later
> parts of the series that can be replaced.
>
> Because changes to Makefile variables tend to have unexpected side  
> effects
> (people have their own definition to override them in their build
> procedures and you can easily break them unless you are careful), I  
> wanted
> to make sure the common part is solid before waiting for the other  
> part.
>
> But if you think it is better not to apply any one, until other parts
> mature, it is Ok by me, too.
I think you should apply it.
	Steffen
Previous: Junio C HamanoNext: Johannes Sixt
Message 13 of 16 in “Move computation of absolute paths from Makefile to runtime and compute prefix on the fly if RUNTIME_PREFIX set”
  1. 1/6 Move computation of absolute paths from Makefile to runtime and compute prefix on the fly if RUNTIME_PREFIX setSteffen Prohaska, Jan 10, 2009
  2. 2/6 Refactor git_set_argv0_path() to git_extract_argv0_path()Steffen Prohaska, Jan 10, 2009
  3. 3/6 Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.Steffen Prohaska, Jan 10, 2009
  4. 4/6 Add calls to git_extract_argv0_path() in programs that call git_config_*Steffen Prohaska, Jan 10, 2009
  5. 5/6 Modify setup_path() to only add git_exec_path() to PATHSteffen Prohaska, Jan 10, 2009
  6. 6/6 Windows: Revert to default paths and convert them by RUNTIME_PREFIXSteffen Prohaska, Jan 10, 2009
  7. Johannes SchindelinJan 10, 2009
  8. Steffen ProhaskaJan 10, 2009
  9. Steffen ProhaskaJan 10, 2009
  10. Junio C HamanoJan 10, 2009
  11. Steffen ProhaskaJan 11, 2009
  12. Junio C HamanoJan 11, 2009
  13. Steffen ProhaskaJan 11, 2009
  14. Johannes SixtJan 13, 2009
  15. Johannes SixtJan 13, 2009
  16. Johannes SixtJan 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.