Re: [PATCH 3/6] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.
On Jan 11, 2009, at 11:21 AM, Junio C Hamano wrote:
Show 25 quoted lines
> My initial impression after reading 1/6 was that no matter how the
> actual
> runtime prefix detection logic that is implemented in the later
> parts of
> the series for particular platform will turn out to be, the update
> to the
> Makefile that is done by 1/6 won't have to change. If I apply 1/6
> first
> without applying anything else, we can make sure that it would not
> regress
> for Unix people (and catch regressions early if any), while Windows
> people
> polish the platform specific parts of the implementation in the later
> parts of the series that can be replaced.
>
> Because changes to Makefile variables tend to have unexpected side
> effects
> (people have their own definition to override them in their build
> procedures and you can easily break them unless you are careful), I
> wanted
> to make sure the common part is solid before waiting for the other
> part.
>
> But if you think it is better not to apply any one, until other parts
> mature, it is Ok by me, too.
I think you should apply it.
Steffen