git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/6] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.

From
Johannes Sixt <j6t@kdbg.org>
Date
Jan 13, 2009, 19:36 UTC
Message-ID
<200901132036.05261.j6t@kdbg.org>
In-Reply-To
<1231595452-27698-3-git-send-email-prohaska@zib.de>
On Samstag, 10. Januar 2009, Steffen Prohaska wrote:
Show 11 quoted lines
> diff --git a/builtin-receive-pack.c b/builtin-receive-pack.c
> index db67c31..bbedcfe 100644
> --- a/builtin-receive-pack.c
> +++ b/builtin-receive-pack.c
> @@ -579,6 +579,9 @@ int cmd_receive_pack(int argc, const char **argv, const
> char *prefix) int i;
>  	char *dir = NULL;
>
> +	if (argv[0] && *argv[0])
> +		git_extract_argv0_path(argv[0]);
> +
This is not necessary because receive-pack is meanwhile a builtin.
Show 13 quoted lines
> diff --git a/upload-pack.c b/upload-pack.c
> index e5adbc0..c469a60 100644
> --- a/upload-pack.c
> +++ b/upload-pack.c
> @@ -616,6 +616,9 @@ int main(int argc, char **argv)
>  	int i;
>  	int strict = 0;
>
> +	if (argv[0] && *argv[0])
> +		git_extract_argv0_path(argv[0]);
> +
>  	for (i = 1; i < argc; i++) {
>  		char *arg = argv[i];
This hunk should be merged into 4/6.
-- Hannes
Previous: Steffen ProhaskaNext: Johannes Sixt
Message 14 of 16 in “Move computation of absolute paths from Makefile to runtime and compute prefix on the fly if RUNTIME_PREFIX set”
  1. 1/6 Move computation of absolute paths from Makefile to runtime and compute prefix on the fly if RUNTIME_PREFIX setSteffen Prohaska, Jan 10, 2009
  2. 2/6 Refactor git_set_argv0_path() to git_extract_argv0_path()Steffen Prohaska, Jan 10, 2009
  3. 3/6 Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.Steffen Prohaska, Jan 10, 2009
  4. 4/6 Add calls to git_extract_argv0_path() in programs that call git_config_*Steffen Prohaska, Jan 10, 2009
  5. 5/6 Modify setup_path() to only add git_exec_path() to PATHSteffen Prohaska, Jan 10, 2009
  6. 6/6 Windows: Revert to default paths and convert them by RUNTIME_PREFIXSteffen Prohaska, Jan 10, 2009
  7. Johannes SchindelinJan 10, 2009
  8. Steffen ProhaskaJan 10, 2009
  9. Steffen ProhaskaJan 10, 2009
  10. Junio C HamanoJan 10, 2009
  11. Steffen ProhaskaJan 11, 2009
  12. Junio C HamanoJan 11, 2009
  13. Steffen ProhaskaJan 11, 2009
  14. Johannes SixtJan 13, 2009
  15. Johannes SixtJan 13, 2009
  16. Johannes SixtJan 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.