Re: [PATCH 3/3] Enable parallel tests

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 8, 2008, 10:26 UTC
Message-ID: <alpine.DEB.1.00.0808081225000.9611@pacific.mpi-cbg.de.mpi-cbg.de>
In-Reply-To: <7vvdycf17a.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 7 Aug 2008, Junio C Hamano wrote:

Show 7 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Parallel mode also triggers removal of the trash directory in the test 
> > itself if everything went fine, so that the trash directories do not 
> > pile up only to be removed at the very end.
> 
> I think making the tests remove their own mess makes sense regardless.

When I add tests, I first run the appropriate t/t*.sh, then expect what is in trash directory, then extend the test. So at least I need an option to keep the directory.

Show 5 quoted lines

> >  clean:
> > -	$(RM) -r 'trash directory' test-results
> > +	$(RM) -rf 'trash directory' test-results
> 
> This is not needed, I think, as RM is defined with -f already.

Okay, thanks.

Ciao, Dscho