Re: [PATCH 3/3] Enable parallel tests

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2008, 06:52 UTC
Message-ID: <7vvdycf17a.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0808080754230.9611@pacific.mpi-cbg.de.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On multiprocessor machines, or with I/O heavy tests (that leave the
> CPU waiting a lot), it makes sense to parallelize the tests.

I was actually thinking about doing this eventually. Thanks for beating me to it.

> Parallel mode also triggers removal of the trash directory in the test
> itself if everything went fine, so that the trash directories do not
> pile up only to be removed at the very end.

I think making the tests remove their own mess makes sense regardless.

I have to wonder why you would want to make this change conditional on MAKEFLAGS. I was envisioning that parallel tests would run in "trash directory/$(basename $0)" or something.

Are there downsides of doing this change unconditionally?

>  clean:
> -	$(RM) -r 'trash directory' test-results
> +	$(RM) -rf 'trash directory' test-results

This is not needed, I think, as RM is defined with -f already.