Re: [PATCH 0/3] Enable parallelized tests

Hi,

On Fri, Aug 08, 2008 at 07:59:08AM +0200, Johannes Schindelin wrote:

Glad to see that others have also picked up this topic. I have also written parallel testing patches back in March, but did not send them out, as there were issues I could not resolve in a satisfactory way - and your patches doesn't seem to address theim either.

There are a few tests involving http transfers, namely:
  t5540-http-push.sh
  t9115-git-svn-dcommit-funky-renames.sh 
  t9118-git-svn-funky-branch-names.sh
  t9120-git-svn-clone-with-percent-escapes.sh

These start an apache web server at the beginning of the test and shut it down after the test finished. Obviously, if you run tests in parallel then these tests can also run concurrently. The problem is with the svn tests, as all those tests use the same directory and port for the web server, resulting in failed tests with -jN.

t5540 is not an issue at the moment, as it uses lib-httpd.sh, hence a different directory and a (possibly) different port than the svn tests. However, who knows, in the future we might have other tests using lib-httpd.sh.

The simplest solution would be to disable parallel testing altogether if http tests are enabled (GIT_TEST_HTTPD and SVN_HTTPD_PORT). But IMHO it would be much better to have only one apache process for the _whole_ testsuite, and to have different paths for the test repos under its documentroot. But yes, it's more difficult to implement; at least I could not do it.

Regards, Gábor