Re: [PATCH 3/3 v2] Enable parallel tests

From: Stephan Beyer <s-beyer@gmx.net>
Date: Aug 8, 2008, 15:03 UTC
Message-ID: <20080808150359.GA25106@leksak.fem-net>
In-Reply-To: <alpine.DEB.1.00.0808081302180.9611@pacific.mpi-cbg.de.mpi-cbg.de>

Hi,

Johannes Schindelin wrote:

Show 10 quoted lines

> @@ -485,7 +490,8 @@ fi
>  . ../GIT-BUILD-OPTIONS
>  
>  # Test repository
> -test="trash directory"
> +test="trash directory.$(basename "$0" .sh)"
> +remove_trash="$(pwd)/$test"
>  rm -fr "$test" || {
>  	trap - exit
>  	echo >&5 "FATAL: Cannot prepare test area"

Please also change t/README, there is a text like:

  [...]
   database and chdir(2) into it.  This directory is 't/trash directory'
   if you must know, but I do not think you care.

If the subdirectory variant is chosen ("trash directory/foo/" instead of "trash directory.foo/"), then

   This directory is below 't/trash directory'."

could be sufficient.

Btw, Junio, about the passage: "I do not think you care" -- I cared :) Sometimes it's nice to change to 'trash directory' and do git log, git diff, git show or whatever.

Regards,
  Stephan

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F