Re: [PATCH 3/6] builtin-help: make it possible to exclude some commands in list_commands()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 28, 2008, 02:43 UTC
- Message-ID
- <alpine.DEB.1.00.0807280442330.5526@eeepc-johanness>
- In-Reply-To
- <7vr69ex00x.fsf@gitster.siamese.dyndns.org>
Hi,
On Sun, 27 Jul 2008, Junio C Hamano wrote:
Show 21 quoted lines
> Miklos Vajna <vmiklos@frugalware.org> writes:
>
> > diff --git a/help.h b/help.h
> > index 0741662..85d3b74 100644
> > --- a/help.h
> > +++ b/help.h
> > @@ -1,7 +1,19 @@
> > #ifndef HELP_H
> > #define HELP_H
> >
> > +struct cmdnames {
> > + int alloc;
> > + int cnt;
> > + struct cmdname {
> > + size_t len;
> > + char name[1];
> > + } **names;
> > +};
>
> I thought we do this kind of thing using FLEX_ARRAY macro. Is there any
> reason its use is not appropriate here?I think that came up in the previous review round: the "name" member _is_ NUL-terminated, but could have a ".exe" suffix. The "len" member has the length excluding ".exe".
Ciao, Dscho