Re: [PATCH 3/6] builtin-help: make it possible to exclude some commands in list_commands()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 28, 2008, 01:36 UTC
- Message-ID
- <7vr69ex00x.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <9cc2813166c8b20ffb411c3a28ad86665e60033b.1217207602.git.vmiklos@frugalware.org>
Miklos Vajna <vmiklos@frugalware.org> writes:
Show 16 quoted lines
> diff --git a/help.h b/help.h
> index 0741662..85d3b74 100644
> --- a/help.h
> +++ b/help.h
> @@ -1,7 +1,19 @@
> #ifndef HELP_H
> #define HELP_H
>
> +struct cmdnames {
> + int alloc;
> + int cnt;
> + struct cmdname {
> + size_t len;
> + char name[1];
> + } **names;
> +};I thought we do this kind of thing using FLEX_ARRAY macro. Is there any reason its use is not appropriate here?