Re: [PATCH 3/6] builtin-help: make it possible to exclude some commands in list_commands()
Junio C Hamano <gitster@pobox.com> writes:
Show 19 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>>> > +struct cmdnames {
>>> > + int alloc;
>>> > + int cnt;
>>> > + struct cmdname {
>>> > + size_t len;
>>> > + char name[1];
>>> > + } **names;
>>> > +};
>>>
>>> I thought we do this kind of thing using FLEX_ARRAY macro. Is there any
>>> reason its use is not appropriate here?
>>
>> I think that came up in the previous review round: the "name" member _is_
>> NUL-terminated, but could have a ".exe" suffix. The "len" member has the
>> length excluding ".exe".
>
> Sorry, but I do understand what you are trying to explain.Yuck, stupid typo; s/do/do not/.