Re: [PATCH 2/2] git-gc: skip stashes when expiring reflogs

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 17, 2008, 09:05 UTC
Message-ID: <alpine.DEB.1.00.0806171000400.6439@racer>
In-Reply-To: <7vy755c0b2.fsf@gitster.siamese.dyndns.org>

Hi,

On Mon, 16 Jun 2008, Junio C Hamano wrote:

Show 25 quoted lines

> From: Junio C Hamano <gitster@pobox.com>
> Date: Sun, 15 Jun 2008 23:48:46 -0700
> Subject: [PATCH] Per-ref reflog expiry configuration
> 
> In addition to gc.reflogexpireunreachable and gc.reflogexpire, this lets
> you set gc.<pattern>.reflogexpireunreachable and gc.<pattern>.reflogexpire
> variables.
> 
> When "git reflog expire" expires reflog entry for $ref, the expiry timers
> are taken from the first <pattern> that matches $ref (and if there isn't
> the global default value is used).
> 
> For example, you could:
> 
> 	[gc "refs/stash"]
> 		reflogexpire = never
> 		reflogexpireunreachable = never
> 
> 	[gc "refs/remotes/*"]
> 		reflogexpire = 7 days
> 		reflogexpireunreachable = 3 days
> 
> 	[gc]
> 		reflogexpire = 90 days
> 		reflogexpireunreachable = 30 days

Isn't this overkill? I mean, we could just change git-stash to output a warning:

	Note: your changes have been stored temporarily.  If you need to 
	keep them permanently, consider putting them into a branch:

		git branch stashed-longer stash

Don't get me wrong: I think per-ref reflog expiry is nifty, but it may be _too_ nifty, i.e. so complicated only power-users will use it.

Ciao, Dscho