Re: [PATCH 2/2] git-gc: skip stashes when expiring reflogs
- From
Mike Hommey <mh@glandium.org>
- Date
- Jun 11, 2008, 21:36 UTC
- Message-ID
- <20080611213648.GA13362@glandium.org>
- In-Reply-To
- <5vuJsx6Kidj7e8EABk_d63dLAYuWF-S880RrJKu83cJo_ejU3VN-VA@cipher.nrlssc.navy.mil>
On Wed, Jun 11, 2008 at 04:29:56PM -0500, Brandon Casey wrote:
Show 5 quoted lines
> The stash makes use of git's reflog mechanism, but it is not a reflog > in the traditional sense. Each entry is a state that the user explicitly > requested git to remember. The stash is generally short-lived, but the > user probably expects that a stash will continue to exist until it is > explicitly deleted. So we should not expire stash entries.
I wonder if it wouldn't make sense to have git reflog expire not expire stashes *at all*. I mean, you don't necessarily cleanup your repo with git gc, and you may end up killing your stashes with git reflog yourself if you don't use the "magic" --exclude...
Mike