Re: [PATCH 2/2] git-gc: skip stashes when expiring reflogs
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Jun 13, 2008, 16:54 UTC
- Message-ID
- <ZTTd7YVht_gFLPWCKTfGHU9iKdkp9sYEZ4upWUptwV0n-_bvgy23kA@cipher.nrlssc.navy.mil>
- In-Reply-To
- <20080613055800.GA26768@sigill.intra.peff.net>
Jeff King wrote:
> On Fri, Jun 13, 2008 at 06:26:28AM +0200, Andreas Ericsson wrote:
> Stashes shouldn't expire, because the user told the stash to save > information. The user considers it a "save" because stashes hold things > forever. Stashes hold things forever because they shouldn't expire.
Maybe the command name is the problem. We know that 'git stash' is short for 'git stash save', so we think we are directing git to "save" something. In the physical world when I "save" something or "stash" it away, even temporarilly, I don't stick it in a garbage can and put it out by the curb. :)
Sorry, that's just what popped into my head :)
-brandon