Re: [PATCH 2/2] git-gc: skip stashes when expiring reflogs

From: Wincent Colaiuta <win@wincent.com>
Date: Jun 13, 2008, 08:41 UTC
Message-ID: <CA1D4ABE-0B83-44CC-B582-1E85784330AB@wincent.com>
In-Reply-To: <20080613054840.GA27122@sigill.intra.peff.net>

El 13/6/2008, a las 7:48, Jeff King escribió:

Show 17 quoted lines

> On Thu, Jun 12, 2008 at 11:46:34AM -0500, Brandon Casey wrote:
>
>>
>> from reflogs even though stashes are implemented using reflogs. The  
>> big
>> difference is that reflogs are created automatically and stashes  
>> are created
>> by explicit user action. Automatically deleting something that git  
>> creates
>> automatically is ok and desirable, doing so for something the user  
>> explicitly
>> created is not necessarily so.
>
> Wincent made this same argument. I don't really agree with it. It is
> predicated on the assumption that stashing something _is_ asking for  
> git
> to remember it.

For me it is quite clear that stashing something _is_ asking for Git to remember it. It's an explicit user action. It's a request to remember something. Whether or not this is actually the best tool for the job of long-term storage is much less important than the fact that the user explicitly requested it. IMO this trumps all other factors. Just because "stash" sounds quicker than "commit" doesn't make it any less of an instruction to Git to store something.

Wincent