Re: t3701 fails if core.filemode disabled

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 18, 2008, 15:35 UTC
Message-ID: <alpine.DEB.1.00.0805181634100.30431@racer>
In-Reply-To: <20080518152337.GB3058@steel.home>

Hi,

On Sun, 18 May 2008, Alex Riesen wrote:

> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>

Are you sure that you want the commit message to read "t3701 fails if core.filemode disabled"? Not rather "skip t3701 if core.filemode is disabled"?

Show 24 quoted lines

> ---
> 
> This is on Cygwin, yes. I have the core.filemode disabled in
> ~/.gitconfig. How about stopping the test before the failing portion
> (only the last two fail, below)?
> 
> $ ./t3701-add-interactive.sh -d -v
> ...
> * expecting success:
>         git reset --hard &&
>         echo content >>file &&
>         chmod +x file &&
>         printf "n\\ny\\n" | git add -p &&
>         git show :file | grep content &&
>         git diff file | grep "new mode"
> 
> HEAD is now at ddca8ca commit
> ddca8caf8c92841fca6311cf3ee839dd304f353d
> --
> diff --git a/file b/file
> index 180b47c..b6f2c08 100644
> --- a/file
> +++ b/file
> @@ -1 +1,2 @@

Are you really, really, really sure you want to have that in the commit? After all, it is _after_ the "---", and the line _does_ begin with "diff --git".

Ciao, Dscho