git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix t3701 if core.filemode disabled

From
Alex Riesen <raa.lkml@gmail.com>
Date
May 22, 2008, 13:20 UTC
Message-ID
<20080522132042.GF3206@steel.home>
In-Reply-To
<20080521143607.GA3575@sigill.intra.peff.net>
Jeff King, Wed, May 21, 2008 16:36:07 +0200:
Show 12 quoted lines
> 2. It's a little hard to see which tests are affected. I would have done
>    something more like:
> 
>   if test "$(git config --bool core.filemode)" = true
>     test_filemode=
>   else
>     test_filemode=:
>   fi
> 
>   $test_filemode test_expect_success ...
> 
>   But maybe that is just overengineering.

But a nice one. I like the idea but Junio already did your other suggestions in master, so I just keep it in mind for the next one

Previous: Jeff KingNext: Junio C Hamano
Message 10 of 15 in “t3701 fails if core.filemode disabled”
  1. Alex RiesenMay 18, 2008
  2. Johannes SchindelinMay 18, 2008
  3. Alex RiesenMay 18, 2008
  4. Jeff KingMay 18, 2008
  5. Alex RiesenMay 18, 2008
  6. Alex RiesenMay 19, 2008
  7. Jeff KingMay 19, 2008
  8. Fix t3701 if core.filemode disabledAlex Riesen, May 20, 2008
  9. Jeff KingMay 21, 2008
  10. Alex RiesenMay 22, 2008
  11. Junio C HamanoMay 22, 2008
  12. Jeff KingMay 22, 2008
  13. Alex RiesenMay 22, 2008
  14. Mark LevedahlMay 19, 2008
  15. Alex RiesenMay 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.