git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t3701 fails if core.filemode disabled

From
Mark Levedahl <mdl123@verizon.net>
Date
May 19, 2008, 00:17 UTC
Message-ID
<4830C71A.60308@verizon.net>
In-Reply-To
<20080518190839.GC15506@sigill.intra.peff.net>
Jeff King wrote:
Show 10 quoted lines
> On Sun, May 18, 2008 at 05:23:37PM +0200, Alex Riesen wrote:
> 
>> This is on Cygwin, yes. I have the core.filemode disabled in
>> ~/.gitconfig. How about stopping the test before the failing portion
>> (only the last two fail, below)?
> 
> What's in your ~/.gitconfig shouldn't have any effect (the test scripts
> take care to avoid looking at anything outside of your git directory).
> But presumably this test is broken on Cygwin, anyway?
>

On Cygwin, support for correctly interpreting the execute bit is governed by the operating system (WindowsNT/XP vs Windows9x), the file system (NTFS vs FAT), and the (NO)NTEA and (NO)NTSEC options via the CYGWIN environment variable. So, there is no simple answer... By default on WindowsNT/XP and running on NTFS, execute modes are supported and the git testsuite currently works.

Some other configurations will not support core.filemode=true, but Cygwin's stated goal is to emulate Linux and it does so by default using current common configurations. Thus, disabling the tests unconditionally on Cygwin would be wrong.

Perhaps the better path is to skip the tests if "$(uname -o)" = "Cygwin" and core.filemode=false, but enable them otherwise, allowing users who know their configuration will not support the execute bit to avoid the test failure.

Mark
Previous: Alex RiesenNext: Alex Riesen
Message 14 of 15 in “t3701 fails if core.filemode disabled”
  1. Alex RiesenMay 18, 2008
  2. Johannes SchindelinMay 18, 2008
  3. Alex RiesenMay 18, 2008
  4. Jeff KingMay 18, 2008
  5. Alex RiesenMay 18, 2008
  6. Alex RiesenMay 19, 2008
  7. Jeff KingMay 19, 2008
  8. Fix t3701 if core.filemode disabledAlex Riesen, May 20, 2008
  9. Jeff KingMay 21, 2008
  10. Alex RiesenMay 22, 2008
  11. Junio C HamanoMay 22, 2008
  12. Jeff KingMay 22, 2008
  13. Alex RiesenMay 22, 2008
  14. Mark LevedahlMay 19, 2008
  15. Alex RiesenMay 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.