Re: [PATCH] Fix t3701 if core.filemode disabled

From: Jeff King <peff@peff.net>
Date: May 22, 2008, 17:55 UTC
Message-ID: <20080522175552.GA14391@sigill.intra.peff.net>
In-Reply-To: <7vzlqiut4a.fsf@gitster.siamese.dyndns.org>

On Thu, May 22, 2008 at 10:49:09AM -0700, Junio C Hamano wrote:

Show 5 quoted lines

> > But a nice one. I like the idea but Junio already did your other
> > suggestions in master, so I just keep it in mind for the next one
> 
> If you like that, I think you would like the way t0050 does even better
> ;-).  It is Steffen Prohaska's invention, IIRC.

Well, you can't test_expect_failure with it. :)

Though I think it is actually nice to mention which tests are being skipped (something I asked for in point 3 of my other message, but which contradicts the example I gave in point 2 of the same message :) ).

So something like:

have_foo=
test_foo() {
  case "$have_foo" in
    t) test_expect_success "$@"
    *) say "skipping test $1 (don't have foo)"
  esac
}

test_expect_success 'see if we have foo' '
  if magic_foo_test; then
    have_foo=t
  fi || true
'
test_foo 'use foo' '...'

-Peff