Re: [PATCH 01/13] pack-objects: extract should_attempt_deltas()
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Mar 20, 2025, 19:48 UTC
- Message-ID
- <afa6b6a2-c301-45e5-a931-66d146392ad1@gmail.com>
- In-Reply-To
- <Z9H2E9hEWgaS9NnP@nand.local>
On 3/12/2025 5:01 PM, Taylor Blau wrote:
> On Mon, Mar 10, 2025 at 01:50:43AM +0000, Derrick Stolee via GitGitGadget wrote:
Show 5 quoted lines
>> +static int should_attempt_deltas(struct object_entry *entry)
>> +{
>> + if (DELTA(entry))
>> + return 0;
>> +...>> - if (DELTA(entry))
Show 8 quoted lines
>> - /* This happens if we decided to reuse existing >> - * delta from a pack. "reuse_delta &&" is implied. >> - */ > > It looks like this comment went away when this part of prepare_pack() > was extracted into should_attempt_deltas(). > >> - continue;
Good catch.
Thanks, -Stolee