Re: [PATCH v2 05/13] pack-objects: introduce GIT_TEST_PACK_PATH_WALK

> On Mon, Mar 24, 2025 at 03:22:41PM +0000, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <stolee@gmail.com>
>>
>> There are many tests that validate whether 'git pack-objects' works as
>> expected. Instead of duplicating these tests, add a new test environment
>> variable, GIT_TEST_PACK_PATH_WALK, that implies --path-walk by default
>> when specified.
> 
> I normally dislike adding new GIT_TEST_* environment variables, because
> I don't think we (myself included) are great about remembering to get
> rid of them. But in this case I think it does make sense to add one.
> 
>> This was useful in testing the implementation of the --path-walk
>> implementation, especially in conjunction with test such as:
> 
> I am not quite following... this sentence sets up a list of tests which
> I was expecting to show some demonstration of how they uniquely
> exercised the path-walk feature. But instead it looks like it describes
> tests that are sensitive to object ordering within packs and thus had to
> have the new GIT_TEST_PACK_PATH_WALK variable unset/set to zero.