Re: [PATCH v2 00/13] PATH WALK II: Add --path-walk option to 'git pack-objects'

From: Taylor Blau <me@ttaylorr.com>
Date: May 2, 2025, 23:44 UTC
Message-ID: <aBVY3u58R23bI/Uo@nand.local>
In-Reply-To: <aBVLC57bMJKjygyi@nand.local>

On Fri, May 02, 2025 at 06:45:31PM -0400, Taylor Blau wrote:

Show 17 quoted lines

> On Fri, May 02, 2025 at 02:24:30PM -0700, Junio C Hamano wrote:
> > > Updates in v2
> > > =============
> > >
> > >  * Re-added a dropped comment when moving code in patch 1.
> > >  * Updated documentation to include interaction with --use-bitmap-index.
> > >  * An UNUSED parameter is now used, reducing the use of global variables
> > >    slightly.
> >
> > The iteration saw no comments from anybody, so I (naturally) forgot
> > about it for quite a long time.  Let me mark it for 'next'.
>
> Sorry, this fell off of my to-do list. I don't want to hold things up
> further, but would appreciate a chance to review this before it hits
> 'next'.
>
> I can take a look now.

OK, I was able to get through the first 8 or so patches in the series, and left a handful of comments throughout. I'm running out of time ATM to finish reviewing, but I should be able to pick it up next Tuesday (I am out of office on Monday).

Again, I am sorry for the delay here. I know that I am holding things up here, but this genuinely fell off of my radar, and Junio's nudge above reminded me. I'll finish reviewing this promptly next week.

Thanks, Taylor