Re: [PATCH v3 00/13] PATH WALK II: Add --path-walk option to 'git pack-objects'
- From
Taylor Blau <me@ttaylorr.com>
- Date
- May 29, 2025, 00:20 UTC
- Message-ID
- <aDeoSW0pZ7r7rCog@nand.local>
- In-Reply-To
- <pull.1819.v3.git.1747419124.gitgitgadget@gmail.com>
On Fri, May 16, 2025 at 06:11:50PM +0000, Derrick Stolee via GitGitGadget wrote:
Show 18 quoted lines
> Updates in v3 > ============= > > Thanks for the review, Taylor. Sorry for my delay in getting back to your > feedback. > > * Documentation has been edited slightly for simplicity. > * is_oid_interesting() was swapped to is_oid_uninteresting() > * sub_list_size renamed to sub_list_nr > * Several uint32_t and uint64_t variables were converted to size_t. > * Several 'unsigned int' variables were required to stay as-is, for now, > until a refactor can be done. > * An unnecessary update of tag_objects was removed. > * The logic and error message around incompatible options is simpler. > * Tests are expanded, especially around config options. > * Fixed commit message typos. > * Extra care around ALLOC_ARRAY() to avoid a zero- or negative-length > array.
Thanks for addressing my feedback :-). This list matches the range-diff below, which looks good. I think that this one is ready to go from my perspective.
Thanks, Taylor