Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:'
- From
- Thorsten Leemhuis <linux@leemhuis.info>
- Date
- Dec 8, 2021, 13:41 UTC
- Message-ID
- <af5ee2e8-cd59-fc9a-35fa-6fec1fc9aa33@leemhuis.info>
- In-Reply-To
- <CAMuHMdWygx9kTemsrZdru-ieYyJXm=8276Q_ZSxZGkqsu5OWVg@mail.gmail.com>
Hi Eric!
On 30.11.21 09:24, Geert Uytterhoeven wrote:
> On Mon, Nov 29, 2021 at 11:29 PM Eric Wong <e@80x24.org> wrote: >> It's a bit much for common cases with git-send-email and >> reasonable MUAs, I think. I don't know if formail is commonly >> installed, nowadays...
Well, after your earlier suggestion I considered to go with this:
- perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Link: https://lore.kernel.org/r/$1|g;' "$1" + perl -pi -e 's|^Message-ID:\s*<?([^>]+)>?$|Link: https://lore.kernel.org/r/$1|i;' "$1"
But...
> Of course ;-) You need it to run checkpatch on patch series obtained > through "b4 am", before you apply them to your tree: > > $ cat *mbx | formail -s scripts/checkpatch.pl
...this made me wonder if formail would be the better solution. I came up with this:
formail -A "Link: https://lore.kernel.org/r/`formail -c -x Message-ID < "${1}" | sed 's!.*<\(.*\)>!\1!'`" < "${1}" | sponge "${1}"
Downsides: instead of perl it requires sed and sponge (part of moreutils, which I guess not everyone has installed; but I tried to avoid a big here document or moving files around).
Is that worth it? Or is there a way to realize this in a more elegant fashion with tools everyone has installed?
Ciao, Thorsten