git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:'

From
EWEric Wong <e@80x24.org>
Date
Nov 26, 2021, 17:11 UTC
Message-ID
<20211126171141.GA21826@dcvr>
In-Reply-To
<12cefa81-495b-3083-5f19-b319c704ebf7@leemhuis.info>
Thorsten Leemhuis <linux@leemhuis.info> wrote:
Show 34 quoted lines
> Ccing Linus Walleij, who added this, and Kees, who apparently came up
> with this originally.
> 
> On 23.11.21 19:52, Eric Wong wrote:
> > Thorsten Leemhuis <linux@leemhuis.info> wrote:
> >> diff --git a/Documentation/maintainer/configure-git.rst b/Documentation/maintainer/configure-git.rst
> >> index 80ae5030a590..8429d45d661c 100644
> >> --- a/Documentation/maintainer/configure-git.rst
> >> +++ b/Documentation/maintainer/configure-git.rst
> > 
> > <snip>, +cc git@vger
> > 
> >> @@ -56,7 +56,7 @@ by adding the following hook into your git:
> >>  	$ cat >.git/hooks/applypatch-msg <<'EOF'
> >>  	#!/bin/sh
> >>  	. git-sh-setup
> >> -	perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Link: https://lore.kernel.org/r/$1|g;' "$1"
> >> +	perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Reviewed: https://lore.kernel.org/r/$1|g;' "$1"
> > 
> > Side note: that regexp should match "Message-ID" case-insensitively.
> > git send-email is an outlier in its capitalization of "Message-Id",
> > most RFCs capitalize it "Message-ID", as do common MUAs.
> 
> Argh :-/
> 
> It's still totally unclear if that or a similar patch will be accepted.
> And even if it is: the "don't do two different things in one commit"
> rule might not be that strict enforced when it comes to the Linux
> kernel's docs, but changing this regexp as part of another patch crosses
> the line.
> 
> IOW: we afaics need a separate patch to make the regexp
> case-insensitively. Eric, do you want to submit one, as you brought it
> up? Or are there any other volunteers?

I suggest you turn this into a 2 patch series to avoid conflicts for a trivial change. I don't even have a kernel worktree handy at the moment (ENOSPC :x)

Previous: Thorsten LeemhuisNext: Thorsten Leemhuis
Message 7 of 19 in “Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:'”
  1. Eric WongNov 23, 2021
  2. Junio C HamanoNov 24, 2021
  3. Eric WongNov 24, 2021
  4. Ævar Arnfjörð BjarmasonNov 26, 2021
  5. Ævar Arnfjörð BjarmasonNov 24, 2021
  6. Thorsten LeemhuisNov 26, 2021
  7. Eric WongNov 26, 2021
  8. Thorsten LeemhuisNov 27, 2021
  9. Eric WongNov 27, 2021
  10. Junio C HamanoNov 27, 2021
  11. Jani NikulaNov 29, 2021
  12. Junio C HamanoNov 29, 2021
  13. Jani NikulaNov 29, 2021
  14. Eric WongNov 29, 2021
  15. Jani NikulaNov 29, 2021
  16. Geert UytterhoevenNov 30, 2021
  17. Thorsten LeemhuisDec 8, 2021
  18. Eric WongDec 8, 2021
  19. Steven RostedtNov 29, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.