Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:'
- From
- Eric Wong <e@80x24.org>
- Date
- Nov 23, 2021, 18:52 UTC
- Message-ID
- <20211123185237.M476855@dcvr>
- In-Reply-To
- <6b760115ecdd3687d4b82680b284f55a04f3ad90.1637566224.git.linux@leemhuis.info>
Thorsten Leemhuis <linux@leemhuis.info> wrote:
> diff --git a/Documentation/maintainer/configure-git.rst b/Documentation/maintainer/configure-git.rst > index 80ae5030a590..8429d45d661c 100644 > --- a/Documentation/maintainer/configure-git.rst > +++ b/Documentation/maintainer/configure-git.rst
<snip>, +cc git@vger
Show 6 quoted lines
> @@ -56,7 +56,7 @@ by adding the following hook into your git: > $ cat >.git/hooks/applypatch-msg <<'EOF' > #!/bin/sh > . git-sh-setup > - perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Link: https://lore.kernel.org/r/$1|g;' "$1" > + perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Reviewed: https://lore.kernel.org/r/$1|g;' "$1"
Side note: that regexp should match "Message-ID" case-insensitively. git send-email is an outlier in its capitalization of "Message-Id", most RFCs capitalize it "Message-ID", as do common MUAs.
git send-email's capitalization does annoy me and I've looked into changing it; but there's a bunch of tests and probably dependent code that also need to be updated...