Re: [PATCH v4 3/5] archive-tar: write extended headers for file sizes >= 8GB
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jul 14, 2016, 16:48 UTC
- Message-ID
- <ac016bb4-9f69-7e03-bc99-7a5bbc1a1a33@kdbg.org>
- In-Reply-To
- <20160630090916.GC17463@sigill.intra.peff.net>
Am 30.06.2016 um 11:09 schrieb Jeff King:
Show 6 quoted lines
> +/* > + * This is the max value that a ustar size header can specify, as it is fixed > + * at 11 octal digits. POSIX specifies that we switch to extended headers at > + * this size. > + */ > +#define USTAR_MAX_SIZE 077777777777UL
This is too large by one bit for our 32-bit unsigned long on Windows:
archive-tar.c: In function 'write_tar_entry': archive-tar.c:295: warning: integer constant is too large for 'unsigned long' type archive-tar.c: In function 'write_global_extended_header': archive-tar.c:332: warning: integer constant is too large for 'unsigned long' type archive-tar.c:335: warning: integer constant is too large for 'unsigned long' type archive-tar.c:335: warning: overflow in implicit constant conversion
-- Hannes