From: Johannes Sixt Date: Thu, 14 Jul 2016 16:48:45 GMT Subject: Re: [PATCH v4 3/5] archive-tar: write extended headers for file sizes >= 8GB Message-ID: In-Reply-To: <20160630090916.GC17463@sigill.intra.peff.net> Am 30.06.2016 um 11:09 schrieb Jeff King: > +/* > + * This is the max value that a ustar size header can specify, as it is fixed > + * at 11 octal digits. POSIX specifies that we switch to extended headers at > + * this size. > + */ > +#define USTAR_MAX_SIZE 077777777777UL This is too large by one bit for our 32-bit unsigned long on Windows: archive-tar.c: In function 'write_tar_entry': archive-tar.c:295: warning: integer constant is too large for 'unsigned long' type archive-tar.c: In function 'write_global_extended_header': archive-tar.c:332: warning: integer constant is too large for 'unsigned long' type archive-tar.c:335: warning: integer constant is too large for 'unsigned long' type archive-tar.c:335: warning: overflow in implicit constant conversion -- Hannes