Re: [PATCH v2 2/2] archive-tar: huge offset and future timestamps would not work on 32-bit

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 16, 2016, 06:28 UTC
Message-ID: <CACsJy8BMn=1SqU5zpALm1KAPwjFjnbm43aaf-FKH6vdAzHjS5g@mail.gmail.com>
In-Reply-To: <xmqqlh13onik.fsf@gitster.mtv.corp.google.com>

On Fri, Jul 15, 2016 at 12:36 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> On Thu, Jul 14, 2016 at 01:43:57PM -0700, Junio C Hamano wrote:
>>
>>> As we are not yet moving everything to size_t but still using ulong
>>> internally when talking about the size of object, platforms with
>>> 32-bit long will not be able to produce tar archive with 4GB+ file,
>>> and cannot grok 077777777777UL as a constant.  Disable the extended
>>> header feature and do not test it on them.
>>
>> I tried testing this in a VM with 32-bit Debian. It fixes the build
>> problems, but t5000 still fails.
>
> Thanks for testing.  I need to find some time hunting for (or
> building) an environment to do that myself.

If you are on a distro with multilib, building git with "CFLAGS=-m32 LDFLAGS=-m32" should do it. That's how i tested the 32-bit offset truncation thing. I may pursue the docker thing soon. At least then you only need to install docker and just build/test (zero docker configuration, assuming all the relevant kernel options are enabled).

-- 
Duy