Re: [PATCH v4 2/5] t5000: test tar files that overflow ustar headers
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 14, 2016, 20:03 UTC
- Message-ID
- <xmqqoa60oulk.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqshvcourb.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
> OK, how about this on top of a replacement for js/t0006-for-v2.9.2 > that I'll send out as a reply to this message?
which is this one, which is largely from your $gmane/299310.
-- >8 -- From: Jeff King <peff@peff.net> Date: Mon, 11 Jul 2016 19:54:18 -0400 Subject: [PATCH] t0006: skip "far in the future" test when unsigned long is not long enough
Git's source code refers to timestamps as unsigned longs. On 32-bit platforms, as well as on Windows, unsigned long is not large enough to capture dates that are "absurdly far in the future".
While we can fix this issue properly by replacing unsigned long with a larger type, we want to be a bit more conservative and just skip those tests on the maint track.
Signed-off-by: Jeff King <peff@peff.net> Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- help.c | 7 +++++++ t/t0006-date.sh | 6 +++--- t/test-lib.sh | 9 +++++++++ 3 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/help.c b/help.c index 19328ea..0cea240 100644 --- a/help.c +++ b/help.c @@ -419,6 +419,13 @@ int cmd_version(int argc, const char **argv, const char *prefix) * with external projects that rely on the output of "git version". */ printf("git version %s\n", git_version_string); + while (*++argv) { + if (!strcmp(*argv, "--build-options")) { + printf("sizeof-unsigned-long: %d", + (int)sizeof(unsigned long)); + /* maybe also save and output GIT-BUILD_OPTIONS? */ + } + } return 0; } diff --git a/t/t0006-date.sh b/t/t0006-date.sh index 04ce535..a0b8497 100755 --- a/t/t0006-date.sh +++ b/t/t0006-date.sh @@ -31,7 +31,7 @@ check_show () { format=$1 time=$2 expect=$3 - test_expect_${4:-success} "show date ($format:$time)" ' + test_expect_success $4 "show date ($format:$time)" ' echo "$time -> $expect" >expect && test-date show:$format "$time" >actual && test_cmp expect actual @@ -50,8 +50,8 @@ check_show iso-local "$TIME" '2016-06-15 14:13:20 +0000' # arbitrary time absurdly far in the future FUTURE="5758122296 -0400" -check_show iso "$FUTURE" "2152-06-19 18:24:56 -0400" -check_show iso-local "$FUTURE" "2152-06-19 22:24:56 +0000" +check_show iso "$FUTURE" "2152-06-19 18:24:56 -0400" 64BIT +check_show iso-local "$FUTURE" "2152-06-19 22:24:56 +0000" 64BIT check_parse() { echo "$1 -> $2" >expect diff --git a/t/test-lib.sh b/t/test-lib.sh index 0055ebb..211f1a8 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -1111,3 +1111,12 @@ run_with_limited_cmdline () { } test_lazy_prereq CMDLINE_LIMIT 'run_with_limited_cmdline true' + +build_option () { + git version --build-options | + sed -ne "s/^$1: //p" +} + +test_lazy_prereq 64BIT ' + test 8 -le "$(build_option sizeof-unsigned-long)" +'
-- 2.9.1-545-g8c0a069