git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/6] builtin/gc: convert to use `packfile_store_get_all_packs()`

From
Taylor Blau <me@ttaylorr.com>
Date
Oct 8, 2025, 20:25 UTC
Message-ID
<aObIw/et7DxB/NrZ@nand.local>
In-Reply-To
<20251007-pks-packfiles-convert-get-all-v1-2-428227657a89@pks.im>
On Tue, Oct 07, 2025 at 02:41:08PM +0200, Patrick Steinhardt wrote:
Show 10 quoted lines
> When running maintenance tasks via git-maintenance(1) we have a couple
> of auto-conditions that check whether or not a specific task should be
> running. One such check is for incremental repacks, which essentially
> use `git multi-pack-index repack` to repack a set of smaller packfiles
> into one larger packfile.
>
> The auto-condition for this task checks how many packfiles there are
> that aren't indexed by any multi-pack index. If there is a sufficient
> number then we execute the above command to combine those into a single
> pack and add them to the MIDX.
s/them/that pack/
Show 5 quoted lines
> As we don't care about MIDX'd packs we use `packfile_store_get_packs()`,
> which knows to not load any packs that are indexed by a MIDX. But as
> explained in the preceding commit, we want to get rid of that function.
>
> We already handle packfiles that have an MIDX alright by the very nature
s/an/a/, s/alright//
Show 5 quoted lines
> of this function, as we explicitly count non-MIDX'd packs. As such, we
> can trivially switch over to use `packfile_store_get_all_packs()`
> instead.
>
> Do so.
;-)

Thanks, Taylor

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 5 of 27 in “packfile: remove `packfile_store_get_packs()`”
  1. 0/6 packfile: remove `packfile_store_get_packs()`Patrick Steinhardt, Oct 7, 2025
  2. 1/6 object-name: convert to use `packfile_store_get_all_packs()`Patrick Steinhardt, Oct 7, 2025
  3. Taylor BlauOct 8, 2025
  4. 2/6 builtin/gc: convert to use `packfile_store_get_all_packs()`Patrick Steinhardt, Oct 7, 2025
  5. Taylor BlauOct 8, 2025
  6. Patrick SteinhardtOct 9, 2025
  7. 3/6 builtin/grep: simplify how we preload packsPatrick Steinhardt, Oct 7, 2025
  8. Taylor BlauOct 8, 2025
  9. 4/6 packfile: drop `packfile_store_get_packs()`Patrick Steinhardt, Oct 7, 2025
  10. Taylor BlauOct 8, 2025
  11. 5/6 packfile: introduce macro to iterate through packsPatrick Steinhardt, Oct 7, 2025
  12. Taylor BlauOct 8, 2025
  13. Patrick SteinhardtOct 9, 2025
  14. 6/6 packfile: rename `packfile_store_get_all_packs()`Patrick Steinhardt, Oct 7, 2025
  15. Taylor BlauOct 8, 2025
  16. Patrick SteinhardtOct 9, 2025
  17. 0/6 packfile: remove `packfile_store_get_packs()`Patrick Steinhardt, Oct 9, 2025
  18. 1/6 object-name: convert to use `packfile_store_get_all_packs()`Patrick Steinhardt, Oct 9, 2025
  19. Justin ToblerOct 14, 2025
  20. 2/6 builtin/gc: convert to use `packfile_store_get_all_packs()`Patrick Steinhardt, Oct 9, 2025
  21. 3/6 builtin/grep: simplify how we preload packsPatrick Steinhardt, Oct 9, 2025
  22. 4/6 packfile: drop `packfile_store_get_packs()`Patrick Steinhardt, Oct 9, 2025
  23. Justin ToblerOct 14, 2025
  24. 5/6 packfile: introduce macro to iterate through packsPatrick Steinhardt, Oct 9, 2025
  25. Justin ToblerOct 14, 2025
  26. 6/6 packfile: rename `packfile_store_get_all_packs()`Patrick Steinhardt, Oct 9, 2025
  27. Justin ToblerOct 14, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.