Re: [PATCH v2 4/6] packfile: drop `packfile_store_get_packs()`
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Oct 14, 2025, 19:11 UTC
- Message-ID
- <yakvujhjgio2g2ynu5735tov2bmsq6cwtaxksvyxik77mrjiuz@c2rspc2k77iq>
- In-Reply-To
- <20251009-pks-packfiles-convert-get-all-v2-4-0d73b87ce711@pks.im>
On 25/10/09 10:01AM, Patrick Steinhardt wrote:
Show 6 quoted lines
> In the preceding commits we have removed all remaining callers of > `packfile_store_get_packs()`, the function is thus unused now. Remove > it. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > ---
[snip]
Show 5 quoted lines
> -/* > - * Get packs managed by the given store. Does not load the MIDX or any packs > - * referenced by it. > - */ > -struct packed_git *packfile_store_get_packs(struct packfile_store *store);
Nice cleanup. Now with `packfile_store_get_packs()` gone, the confusing stateful behavior here is no more. :)
-Justin