From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 08 Oct 2025 20:25:39 GMT
Subject: Re: [PATCH 2/6] builtin/gc: convert to use `packfile_store_get_all_packs()`
Message-ID: <aObIw/et7DxB/NrZ@nand.local>
In-Reply-To: <20251007-pks-packfiles-convert-get-all-v1-2-428227657a89@pks.im>

On Tue, Oct 07, 2025 at 02:41:08PM +0200, Patrick Steinhardt wrote:
> When running maintenance tasks via git-maintenance(1) we have a couple
> of auto-conditions that check whether or not a specific task should be
> running. One such check is for incremental repacks, which essentially
> use `git multi-pack-index repack` to repack a set of smaller packfiles
> into one larger packfile.
>
> The auto-condition for this task checks how many packfiles there are
> that aren't indexed by any multi-pack index. If there is a sufficient
> number then we execute the above command to combine those into a single
> pack and add them to the MIDX.

s/them/that pack/

> As we don't care about MIDX'd packs we use `packfile_store_get_packs()`,
> which knows to not load any packs that are indexed by a MIDX. But as
> explained in the preceding commit, we want to get rid of that function.
>
> We already handle packfiles that have an MIDX alright by the very nature

s/an/a/, s/alright//

> of this function, as we explicitly count non-MIDX'd packs. As such, we
> can trivially switch over to use `packfile_store_get_all_packs()`
> instead.
>
> Do so.

;-)

Thanks,
Taylor