Re: [PATCH v7 5/9] varint: use explicit width for integers

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 2, 2025, 07:30 UTC
Message-ID: <aN4qDbvN10nvNMOo@pks.im>
In-Reply-To: <CAH=ZcbBQk9xmTF-m6tX6F+PRmnUSoevyFFvK-fAc3uzL3NvqSQ@mail.gmail.com>

On Wed, Oct 01, 2025 at 11:22:44AM -0600, Ezekiel Newren wrote:

Show 16 quoted lines

> On Tue, Sep 30, 2025 at 7:34 AM Kristoffer Haugsbakk
> <kristofferhaugsbakk@fastmail.com> wrote:
> >
> > On Thu, Sep 25, 2025, at 08:30, Patrick Steinhardt wrote:
> > > The varint subsystem currently uses implcit widths for integers. On the
> >
> > s/implcit/implicit/
> >
> > > one hand we use `uintmax_t` for the actual value. On the other hand, we
> > > use `int` for the length of the encoded varint.
> > >
> > > Both of these have known maximum vaules, as we only support at most 16
> >
> > s/vaules/values/
> 
> Other than the typos this looks good.

Thanks, both of you! I'll send another (hopefully the last) iteration now. Guess we'll now have to decide whether we want to try this Rust experiment or not.

Patrick