Re: [PATCH RFC 2/3] rust: implement a test balloon via the "varint" subsystem
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 5, 2025, 07:54 UTC
- Message-ID
- <aLqXGP5K6so13rCc@pks.im>
- In-Reply-To
- <aLoUuxfQmxHdqiYe@fruit.crustytoothpaste.net>
On Thu, Sep 04, 2025 at 10:37:47PM +0000, brian m. carlson wrote:
Show 27 quoted lines
> On 2025-09-04 at 14:26:44, Patrick Steinhardt wrote:
> > diff --git a/meson.build b/meson.build
> > index 1c0e98bbc14..b52a68b0bb6 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1713,6 +1712,10 @@ rust_option = get_option('rust').disable_auto_if(not rust_available)
> >
> > if rust_option.allowed() and meson.version().version_compare('>=1.9.0')
> > subdir('src')
> > +else
> > + libgit_sources += [
> > + 'varint.c',
> > + ]
> > endif
>
> Can we also add a #define constant when building? For instance, if I'm
> writing interop code in Rust, I'll need to be able to do something like
> this:
>
> int do_foobar()
> {
> #ifdef RUST
> /* Call some code */
> #else
> die(_("interoperability not supported"));
> #endif
> }Sure, that sounds like a useful addition. I can add it to the next version already if you want to, or we can add it at a later point once it becomes needed.
Patrick