git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/3] remote.c: convert if-else ladder to switch

From
Denton Liu <liu.denton@gmail.com>
Date
Aug 8, 2025, 07:14 UTC
Message-ID
<aJWjxbiyQ0cuiQku@generichostname>
In-Reply-To
<aJWOcDN2LZaMzaqH@pks.im>
On Fri, Aug 08, 2025 at 07:43:12AM +0200, Patrick Steinhardt wrote:
> We can't remove the `type` variable in this patch already -- it's still
> used by this call to `BUG()`. But we can drop the variable in the next
> patch, where that call is converted to `advise()`.

Ugh, that's what I get for rushing this patchset out without doing a test compile :/

Thanks for catching that. Another patchset incoming
-Denton
Previous: Patrick SteinhardtNext: Denton Liu
Message 27 of 34 in “remote.c: remove erroneous BUG case”
  1. 0/2 remote.c: remove erroneous BUG caseDenton Liu, Aug 4, 2025
  2. 1/2 t5516: introduce 'push ref expression with non-existent oid src'Denton Liu, Aug 4, 2025
  3. 2/2 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 4, 2025
  4. Junio C HamanoAug 4, 2025
  5. 0/2 *** SUBJECT HERE ***Denton Liu, Aug 5, 2025
  6. 1/2 t5516: introduce 'push ref expression with non-existent oid src'Denton Liu, Aug 5, 2025
  7. Patrick SteinhardtAug 5, 2025
  8. Junio C HamanoAug 5, 2025
  9. 2/2 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 5, 2025
  10. Patrick SteinhardtAug 5, 2025
  11. 0/2 remote.c: remove erroneous BUG caseDenton Liu, Aug 6, 2025
  12. 1/2 t5516: remove surrounding empty lines in test bodiesDenton Liu, Aug 6, 2025
  13. Patrick SteinhardtAug 6, 2025
  14. 2/2 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 6, 2025
  15. Patrick SteinhardtAug 6, 2025
  16. Junio C HamanoAug 6, 2025
  17. remote.c: convert if-else tower to switchDenton Liu, Aug 7, 2025
  18. Patrick SteinhardtAug 7, 2025
  19. remote.c: convert if-else tower to switchDenton Liu, Aug 7, 2025
  20. Ben KnobleAug 7, 2025
  21. Eric SunshineAug 7, 2025
  22. Junio C HamanoAug 7, 2025
  23. 0/3 remote.c: remove erroneous BUG caseDenton Liu, Aug 8, 2025
  24. 1/3 t5516: remove surrounding empty lines in test bodiesDenton Liu, Aug 8, 2025
  25. 2/3 remote.c: convert if-else ladder to switchDenton Liu, Aug 8, 2025
  26. Patrick SteinhardtAug 8, 2025
  27. Denton LiuAug 8, 2025
  28. 3/3 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 8, 2025
  29. 0/3 remote.c: remove erroneous BUG caseDenton Liu, Aug 8, 2025
  30. 1/3 t5516: remove surrounding empty lines in test bodiesDenton Liu, Aug 8, 2025
  31. 2/3 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 8, 2025
  32. 3/3 remote.c: convert if-else ladder to switchDenton Liu, Aug 8, 2025
  33. Patrick SteinhardtAug 8, 2025
  34. Junio C HamanoAug 8, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.