Re: [PATCH v2] remote.c: convert if-else tower to switch

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 7, 2025, 17:19 UTC
Message-ID: <CAPig+cQW2t+PC6R7YKaBTPHr96oyBerXv5UwCUhGpXYUqn-HgA@mail.gmail.com>
In-Reply-To: <F3252723-7E5E-4E84-94E4-5FC00298BAB2@gmail.com>

On Thu, Aug 7, 2025 at 8:35 AM Ben Knoble <ben.knoble@gmail.com> wrote:

Show 15 quoted lines

> > Le 7 août 2025 à 05:20, Denton Liu <liu.denton@gmail.com> a écrit :
> > For better readability, convert the if-else tower into a switch
> > statement.
> >
> > Signed-off-by: Denton Liu <liu.denton@gmail.com>
> > ---
> > diff --git a/remote.c b/remote.c
> > index 465e0ea0eb..029b1fa93b 100644
> > --- a/remote.c
> > +++ b/remote.c
> > @@ -1171,7 +1171,6 @@ static void show_push_unqualified_ref_name_error(const char *dst_value,
> >
> > Range-diff against v1:
>
> Don’t we normally put single-patch notes like a range-diff right after the triple dash? I have a feeling this format breaks git-am on the receiving side, though I haven’t actually tried it.

Not since 2fa04cebfb (format-patch: move range/inter diff at the end of a single patch output, 2024-05-24).