git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] remote.c: convert if-else tower to switch

From
Patrick Steinhardt <ps@pks.im>
Date
Aug 7, 2025, 04:38 UTC
Message-ID
<aJQtrgZ1fldaIy4E@pks.im>
In-Reply-To
<5866818859be97c091c40602974629eb7e463623.1754540903.git.liu.denton@gmail.com>
On Wed, Aug 06, 2025 at 09:30:20PM -0700, Denton Liu wrote:
Show 20 quoted lines
> For better readability, convert the if-else tower into a switch
> statement.
> 
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
> Thanks for the suggestion, both. Please queue this patch wherever it
> makes the most sense to do so (either with the existing series or on its
> own separate branch).
> 
>  remote.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/remote.c b/remote.c
> index 465e0ea0eb..c7ae18fcfa 100644
> --- a/remote.c
> +++ b/remote.c
> @@ -1197,29 +1197,35 @@ static void show_push_unqualified_ref_name_error(const char *dst_value,
>  		    "match_explicit_lhs() should catch this!",
>  		    matched_src_name);
>  	type = odb_read_object_info(the_repository->objects, &oid, NULL);
Nit: we can also drop the `type` variable, we don't need it for anything
but the value of the switch as far as I can see.
Thanks!
Patrick
Previous: Denton LiuNext: Denton Liu
Message 18 of 34 in “remote.c: remove erroneous BUG case”
  1. 0/2 remote.c: remove erroneous BUG caseDenton Liu, Aug 4, 2025
  2. 1/2 t5516: introduce 'push ref expression with non-existent oid src'Denton Liu, Aug 4, 2025
  3. 2/2 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 4, 2025
  4. Junio C HamanoAug 4, 2025
  5. 0/2 *** SUBJECT HERE ***Denton Liu, Aug 5, 2025
  6. 1/2 t5516: introduce 'push ref expression with non-existent oid src'Denton Liu, Aug 5, 2025
  7. Patrick SteinhardtAug 5, 2025
  8. Junio C HamanoAug 5, 2025
  9. 2/2 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 5, 2025
  10. Patrick SteinhardtAug 5, 2025
  11. 0/2 remote.c: remove erroneous BUG caseDenton Liu, Aug 6, 2025
  12. 1/2 t5516: remove surrounding empty lines in test bodiesDenton Liu, Aug 6, 2025
  13. Patrick SteinhardtAug 6, 2025
  14. 2/2 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 6, 2025
  15. Patrick SteinhardtAug 6, 2025
  16. Junio C HamanoAug 6, 2025
  17. remote.c: convert if-else tower to switchDenton Liu, Aug 7, 2025
  18. Patrick SteinhardtAug 7, 2025
  19. remote.c: convert if-else tower to switchDenton Liu, Aug 7, 2025
  20. Ben KnobleAug 7, 2025
  21. Eric SunshineAug 7, 2025
  22. Junio C HamanoAug 7, 2025
  23. 0/3 remote.c: remove erroneous BUG caseDenton Liu, Aug 8, 2025
  24. 1/3 t5516: remove surrounding empty lines in test bodiesDenton Liu, Aug 8, 2025
  25. 2/3 remote.c: convert if-else ladder to switchDenton Liu, Aug 8, 2025
  26. Patrick SteinhardtAug 8, 2025
  27. Denton LiuAug 8, 2025
  28. 3/3 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 8, 2025
  29. 0/3 remote.c: remove erroneous BUG caseDenton Liu, Aug 8, 2025
  30. 1/3 t5516: remove surrounding empty lines in test bodiesDenton Liu, Aug 8, 2025
  31. 2/3 remote.c: remove BUG in show_push_unqualified_ref_name_error()Denton Liu, Aug 8, 2025
  32. 3/3 remote.c: convert if-else ladder to switchDenton Liu, Aug 8, 2025
  33. Patrick SteinhardtAug 8, 2025
  34. Junio C HamanoAug 8, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.