Re: [PATCH 03/10] builtin: use default hash when outside a repository

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 1, 2025, 11:35 UTC
Message-ID: <aGPIBa-1xjqk8EEE@pks.im>
In-Reply-To: <20250620011943.586596-4-sandals@crustytoothpaste.net>

On Fri, Jun 20, 2025 at 01:19:35AM +0000, brian m. carlson wrote:

Show 6 quoted lines

> We have some commands that can operate inside or outside a repository.
> If we're operating outside a repository, we clearly cannot use the
> repository's hash algorithm as a default since it doesn't exist, so
> instead, let's pick the default instead of specifically SHA-1.  Right
> now this results in no functional change since the default is SHA-1, but
> that may change in the future.

With the preceding commit in mind that introduced GIT_HASH_ORIGINAL you could also argue that those callsites should be converted to use that define instead. We always used to treat them as SHA1 repositories, and we have no better way of telling otherwise, so we use the historical value of SHA1 so that scripts aren't dependent on how exactly Git was built.

Patrick