Re: [PATCH 04/10] Use original hash for legacy formats

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jun 20, 2025, 20:51 UTC
Message-ID: <aFXJunWKq28BeX-a@fruit.crustytoothpaste.net>
In-Reply-To: <xmqqcyay7ale.fsf@gitster.g>

On 2025-06-20 at 14:26:37, Junio C Hamano wrote:

> If we call use a name with SHA-1 in it (e.g., GIT_HASH_MUST_BE_SHA1)
> from the beginning, perhaps we do not have to rename _ORIGINAL later?

We could call it GIT_HASH_LEGACY_SHA1 if you prefer that. I originally considered something like GIT_HASH_GOOD_OLD_REV (GOOD_OLD_REV comes from ext2's much more rigid and less extendable v0 rather than its newer v1 format), but I felt like that would be too esoteric and not document things well enough.

I'm also open to other ideas for naming if someone has them. After all, naming things is one of the hard problems in computer science.

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.