[PATCH v2 02/11] hash: add a constant for the legacy hash algorithm
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jul 1, 2025, 21:22 UTC
- Message-ID
- <20250701212237.766774-3-sandals@crustytoothpaste.net>
- In-Reply-To
- <20250701212237.766774-1-sandals@crustytoothpaste.net>
We have a a variety of uses of GIT_HASH_SHA1 littered throughout our code. Some of these really mean to represent specifically SHA-1, but some actually represent the original hash algorithm used in Git which is implied by older, legacy formats and protocols which do not contain hash information. For instance, the bundle v1 and v2 formats do not contain hash algorithm information, and thus SHA-1 is implied by the use of these formats.
Add a constant for documentary purposes which indicates this value. It will always be the same as SHA-1, since this is an essential part of these formats, but its use indicates this particular reason and not any other reason why SHA-1 might be used.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> --- hash.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/hash.h b/hash.h index 0d3d85e04c..953e840d15 100644 --- a/hash.h +++ b/hash.h @@ -176,6 +176,8 @@ static inline void git_SHA256_Clone(git_SHA256_CTX *dst, const git_SHA256_CTX *s #define GIT_HASH_NALGOS (GIT_HASH_SHA256 + 1) /* Default hash algorithm if unspecified. */ #define GIT_HASH_DEFAULT GIT_HASH_SHA1 +/* Legacy hash algorithm. Implied for older data formats which don't specify. */ +#define GIT_HASH_SHA1_LEGACY GIT_HASH_SHA1 /* "sha1", big-endian */ #define GIT_SHA1_FORMAT_ID 0x73686131