Re: [PATCH 2/3] t7450: test submodule urls
- From
Victoria Dye <vdye@github.com>
- Date
- Jan 11, 2024, 17:23 UTC
- Message-ID
- <a9afd237-e048-43eb-922a-2734e573a644@github.com>
- In-Reply-To
- <xmqqttnmfarm.fsf@gitster.g>
Junio C Hamano wrote:
Show 13 quoted lines
> "Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> +#define TEST_TOOL_CHECK_URL_USAGE \
>> + "test-tool submodule check-url <url>"
>> +static const char *submodule_check_url_usage[] = {
>> + TEST_TOOL_CHECK_URL_USAGE,
>> + NULL
>> +};
>
> Granted, the entry that follows this new one already uses the same
> pattern, but TEST_TOOL_CHECK_URL_USAGE being used only once here and
> nowhere else, with its name almost as long as the value it expands to,
> I found it unnecessarily verbose and confusing.This is only used once because I missed the second place it should be used (in 'submodule_usage[]'). It's still somewhat verbose, but once I fix that it'll at least have the benefit of avoiding some duplication.